Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 92.46% 92.94% +0.48%
==========================================
Files 4 4
Lines 146 156 +10
==========================================
+ Hits 135 145 +10
Misses 11 11 🚀 New features to boost your workflow:
|
ycexiao
commented
Apr 18, 2026
Contributor
Author
ycexiao
left a comment
ycexiao
left a comment
There was a problem hiding this comment.
@sbillinge, it's ready for review.
| @@ -0,0 +1,24 @@ | |||
| **Added:** | |||
|
|
|||
| * Also add ``diffpy.apps`` as an entry point. | |||
Contributor
Author
There was a problem hiding this comment.
The package name(diffpy.apps) and the CLI app(diffpy.app) name are easy to confuse. We use diffpy.app because each time only one app is invoked.
Also add diffpy.apps as an entry point for user's convenience when they didn't notice the difference between the package name and the entry point.
Contributor
|
Nice. Very kind to the users! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Closes #13
Update
READMEand adddiffpy.appsentry point according to theREADME.What should the reviewer(s) do?